apache / parquet-java

Apache Parquet Java
https://parquet.apache.org/
Apache License 2.0
2.58k stars 1.4k forks source link

PARQUET-2465: Fall back to HadoopConfig (#1339) #1342

Closed Fokko closed 5 months ago

Fokko commented 5 months ago

Backporting the fallback logic

We see that this causes the 1.14 to be incompatible with the previous releases. The config will be created and right after that the getWriteSupport(conf) is called.

But since this method is freshly introduced:

    protected WriteSupport<T> getWriteSupport(ParquetConfiguration conf) {
      throw new UnsupportedOperationException(
          "Override ParquetWriter$Builder#getWriteSupport(ParquetConfiguration)");
    }

Make sure you have checked all steps below.

Jira

Tests

Commits

Style

Documentation

wgtmac commented 5 months ago

Thanks for backporting!

BTW, I'm still on vacation until May 6th. I can restart preparation for RC1 after that if there is no hurry.

Fokko commented 5 months ago

@wgtmac It would be nice to get the RC out because of the Spark 4.0 release. I can also send out the mail for RC1 and then you can wrap it up when you're back from vacation

wgtmac commented 5 months ago

That sounds good. Thanks @Fokko!