However, if you have these null, we really didn't need to go through Hadoop. Also, it calls a helper method in ParquetOutputFormat. This class inherits from Hadoop's FileOutputFormat. So calling this method at all, requires Hadoop classes. To resolve this, I moved this helper into a package-protected EncryptionPropertiesHelper class.
Make sure you have checked all steps below.
Jira
[x] My PR addresses the following Parquet Jira issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
testLoadEncPropertiesFactoryParquetConfiguration
Commits
[x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
from "How to write a good git commit message":
Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"
Style
[x] My contribution adheres to the code style guidelines and Spotless passes.
To apply the necessary changes, run mvn spotless:apply -Pvector-plugins
Documentation
[x] In case of new functionality, my PR adds documentation that describes how to use it.
All the public functions and the classes in the PR contain Javadoc that explain what it does
If you want to write an unencrypted Parquet file without Hadoop, the existing code will use Hadoop to try to get encryption properties.
https://github.com/apache/parquet-java/blob/fbe13d89ae4193be12c164d4bb5342c5eba3963f/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java#L388-L393
However, if you have these
null
, we really didn't need to go through Hadoop. Also, it calls a helper method inParquetOutputFormat
. This class inherits from Hadoop'sFileOutputFormat
. So calling this method at all, requires Hadoop classes. To resolve this, I moved this helper into a package-protectedEncryptionPropertiesHelper
class.Make sure you have checked all steps below.
Jira
Tests
Commits
Style
mvn spotless:apply -Pvector-plugins
Documentation