search

apache / parquet-java

Apache Parquet Java
https://parquet.apache.org/
Apache License 2.0
2.49k stars 1.37k forks source link

Close resources in finally block in ParquetFileWriter#end #2905

Closed asfimport closed 1 month ago

asfimport commented 1 month ago

ParquetFileWriter#end currently will write out the footer and then do the close. However, the close is not within a finally block so it's technically possible that something fails within the footer write and we don't free up resources.

Reporter: Amogh Jahagirdar / @amogh-jahagirdar Assignee: Amogh Jahagirdar / @amogh-jahagirdar

PRs and other links:

Note: This issue was originally created as PARQUET-2472. Please see the migration documentation for further details.

asfimport commented 1 month ago

Amogh Jahagirdar / @amogh-jahagirdar: I've raised https://github.com/apache/parquet-mr/pull/1350 to address this