search

apache / parquet-java

Apache Parquet Java
https://parquet.apache.org/
Apache License 2.0
2.65k stars 1.41k forks source link

Adjust PR template to reference GitHub issue tracker #2932

Closed rok closed 5 months ago

rok commented 5 months ago

Now that we moved issue tracking to GitHub we should adjust our pull request template.

wgtmac commented 5 months ago

I'm not sure it is a good idea to copy https://github.com/apache/arrow/blob/main/dev/merge_arrow_pr.py so we can automatically close related issue while merging PRs.

rok commented 5 months ago

I wonder if we could avoid the script and just use the merge button? @raulcd Why is Arrow currently using the script instead of the button?

raulcd commented 5 months ago

The merge script still does several issues like, validate the milestone is set correctly, updating the Title name, authors, setting the correct lables if necessary. We could investigate if some of those issues could be automated when merging with the merge button but the one I am not entirely sure how we would like to do is the milestone validation and setting we do before merging.

rok commented 5 months ago

That sounds like we probably don't want to use the merge button then. For automated closing of connected issues after merges we could use github automation.

wgtmac commented 5 months ago

That sounds like we probably don't want to use the merge button then. For automated closing of connected issues after merges we could use github automation.

Sounds good. There are always new stuffs to learn :)