search

apache / parquet-java

Apache Parquet Java
https://parquet.apache.org/
Apache License 2.0
2.65k stars 1.41k forks source link

GH-2952: Add maven wrapper #2953

Closed nastra closed 2 months ago

nastra commented 4 months ago

Rationale for this change

Having a maven wrapper in the project removes the burden for users to have maven installed on their system. The wrapper was added by running mvn wrapper:wrapper

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

nastra commented 4 months ago

As a next step (please let me know if that should be within this PR) I was planning to update all mvn references in the codebase to ./mvnw

wgtmac commented 4 months ago

This looks nice. However, my concern is the maintenance burden of the new script.

@julienledem @gszadovszky WDYT?

joyCurry30 commented 4 months ago

Missing mvnw.cmd

nastra commented 4 months ago

This looks nice. However, my concern is the maintenance burden of the new script.

@julienledem @gszadovszky WDYT?

@wgtmac typically this script doesn't require any maintenance and will be updated automatically when updating the underlying maven version through the wrapper. That doesn't mean that every maven version bump requires an updated script, just that the wrapper task will update the script if necessary