search

apache / parquet-java

Apache Parquet Java
https://parquet.apache.org/
Apache License 2.0
2.65k stars 1.41k forks source link

GH-2962: Set dictionary_page_offset even when encoding_stats are missing #3012

Closed mothukur closed 1 month ago

mothukur commented 2 months ago

Rationale for this change

Currently dictionary page offset is not being set when there are no encoding statistics. This is creating problem while creating parquet files using the addRowGroup method in ParquetMetadataConverter

What changes are included in this PR?

Set dictionary_page_offset value when column has any dictionary pages.

Are these changes tested?

Yes

Are there any user-facing changes?

No

Closes #2962

mothukur commented 1 month ago

@wgtmac could you merge this ?

wgtmac commented 1 month ago

Just merged it. Thanks @mothukur!