apache / parquet-java

Apache Parquet Java
https://parquet.apache.org/
Apache License 2.0
2.65k stars 1.41k forks source link

Bump Scala to 2.12.20 #3044

Closed Fokko closed 6 days ago

Fokko commented 2 weeks ago

Adds support for JDK21+:

Or see: https://endoflife.date/scala#jdk-compatibility

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

pan3793 commented 2 weeks ago

Is the parquet-scala module actually being used?

Fokko commented 2 weeks ago

@pan3793 I don't have full visibility on that, but it doesn't like it, looking at Usages in Maven Central: https://mvnrepository.com/artifact/org.apache.parquet/parquet-scala

Might be good to see if we can retire some modules that are not used anymore (I think parquet-pig is also another good candidate).

pan3793 commented 2 weeks ago

+1 for retiring the parquet-scala module, or even dropping it directly.

there is only one class in the parquet-scala module, users are easy to copy and embed it if we drop the parquet-scala module.

additionally, it's rare to publish a scala lib that only supports a single scala binary version, most scala libs support 2~3 scala binary versions in each version

Fokko commented 2 weeks ago

@pan3793 I agree, are you interested in raising a [DISCUSS] on the mailinglist?

pan3793 commented 2 weeks ago

@Fokko https://lists.apache.org/thread/scdq9t2gvvs4glhq0qx4qcvfp62j793s

Fokko commented 6 days ago

Closing this in favor of https://github.com/apache/parquet-java/pull/3063