search

apache / pekko-connectors

Apache Pekko Connectors is a Reactive Enterprise Integration library for Java and Scala, based on Reactive Streams and Apache Pekko.
https://pekko.apache.org/
Apache License 2.0
64 stars 32 forks source link

[kinesis] transitive dependency on scala 2.12 jar #479

Open pjfanning opened 9 months ago

pjfanning commented 9 months ago

I'm not sure if there is anything that can be done to fix this but logging for visibility.

Our Kinesis Connector depends on "software.amazon.kinesis:amazon-kinesis-client" and this depends on "com.kjetland:mbknor-jackson-jsonschema_2.12".

com.kjetland:mbknor-jackson-jsonschema_2.12:1.0.39 software.amazon.glue:schema-registry-serde:1.1.17 software.amazon.kinesis:amazon-kinesis-client:2.5.4

This dependency is brought in transitively and is hardcoded as Scala 2.12 - ie it does not adjust to the Scala version used by Pekko users. We could exclude the dependency and add our own dependency on "com.kjetland" %% "mbknor-jackson-jsonschema" but there is no Scala 3 release for this jar.

Basically, "com.kjetland" %% "mbknor-jackson-jsonschema" appears not to be actively supported. It hasn't been released since 2020 and has some old Jackson dependencies.

I can raise an issue at https://github.com/mbknor/mbknor-jackson-jsonSchema

raboof commented 9 months ago

We could exclude the dependency and add our own dependency on "com.kjetland" %% "mbknor-jackson-jsonschema" but there is no Scala 3 release for this jar.

Could we use CrossVersion.for3Use2_13?

pjfanning commented 9 months ago

@jtjeferreira You appear to use the Kinesis connector. Have you run into this issue or do you have any thoughts? Is it possible that we don't use the code in software.amazon.kinesis:amazon-kinesis-client that requires mbknor-jackson-jsonSchema?

jtjeferreira commented 9 months ago

@jtjeferreira You appear to use the Kinesis connector. Have you run into this issue or do you have any thoughts? Is it possible that we don't use the code in software.amazon.kinesis:amazon-kinesis-client that requires mbknor-jackson-jsonSchema?

I never noticed the use of a _2.12 dependency because in my projects I exclude the software.amazon.glue:schema-registry-serde...

I found this draft PR https://github.com/awslabs/aws-glue-schema-registry/pull/315 and I think we should not be doing anything and let AWS solve it