search

apache / pekko-connectors

Apache Pekko Connectors is a Reactive Enterprise Integration library for Java and Scala, based on Reactive Streams and Apache Pekko.
https://pekko.apache.org/
Apache License 2.0
56 stars 27 forks source link

Move AWS SPI code into Pekko repo #648

Closed pjfanning closed 3 weeks ago

pjfanning commented 1 month ago
pjfanning commented 1 month ago

@mdedetrich I'm thinking of just removing the integration tests. They require real AWS access. There are unit tests that use testcontainers. I think those are enough. Is this ok?

mdedetrich commented 1 month ago

@mdedetrich I'm thinking of just removing the integration tests. They require real AWS access. There are unit tests that use testcontainers. I think those are enough. Is this ok?

So we do actually have a real AWS account that is provided by Apache INFRA and it is currently being used by S3 integration tests and there is a github action that triggers it daily off the main branch (note that the reason this is run off the main branch is due to the fact that secrets are not available in pull requests).

Initially I would suggest trying to enable the tests and if its too much effort we can disable them, file an issue and try and we can try and re-enable them later. The reason I am suggesting this is that the core reason for me pushing for the AWS S3 integration tests is we did have an actual case of a regression that wasn't caught since initially there wasn't tests running against it.

mdedetrich commented 1 month ago

Oh and I forgot to mention that if you do end up enabling integration tests, you have to work with Apache INFRA so that they can add in the necessary roles/permissions in the AWS account for whatever is being tested.

This does require some back and forth so given that it might make sense to do it in a different PR, but regardless I think we should still aim to have these tests in place

mdedetrich commented 1 month ago

@pjfanning Is this ready?

pjfanning commented 1 month ago

I'll leave the integration tests to another time but I have a couple of more things to do with this PR - it is pretty close now.

He-Pin commented 1 month ago

I will take a look this weekend

mdedetrich commented 1 month ago

This slipped off the table, will check it out tonight

pjfanning commented 3 weeks ago

Would anyone have time to review this PR? I'm hoping to finalise the 1.1.0-M1 RC1 over the next week or so.