apache / pekko-connectors

Apache Pekko Connectors is a Reactive Enterprise Integration library for Java and Scala, based on Reactive Streams and Apache Pekko.
https://pekko.apache.org/
Apache License 2.0
56 stars 27 forks source link

Adding Jakarta Messaging 3.0 support #674

Closed samueleresca closed 14 hours ago

samueleresca commented 1 month ago

See: #483

Few notes regarding the PR after spending some time on this:

pjfanning commented 1 week ago

@samueleresca is this PR complete? I'm hoping to start a discussion about a Pekko Connectors 1.1.0-M1 release. This can be delayed until after that release if that suits you better.

samueleresca commented 1 week ago

@samueleresca is this PR complete? I'm hoping to start a discussion about a Pekko Connectors 1.1.0-M1 release. This can be delayed until after that release if that suits you better.

There is a comment @laglangyue that I need to address, apart from that it is ready. It would be great to merge this for Pekko Connectors 1.1.0-M1.

pjfanning commented 22 hours ago

@samueleresca This is the last PR blocking the release. Again, I'm happy to move on with the M1 release without this and to have it merged prior to the full 1.1.0 release.

samueleresca commented 14 hours ago

@samueleresca This is the last PR blocking the release. Again, I'm happy to move on with the M1 release without this and to have it merged prior to the full 1.1.0 release.

@pjfanning The PR is ready apart few minor comments that I think shouldn't block the merge. So I'm happy to get the approval and get this merged