Closed mdedetrich closed 1 year ago
It's needed if you use pekko-grpc from Java.
Okay I will look into it then, not exactly sure whats special about this project that we need Gradle for Java specifically
This component relies on code generation in the projects that use it, and provides Maven, gradle and sbt plugins to achieve that. I think it should be possible to use the generic maven/gradle/sbt protobuf plugins and "plug in" the Akka gRPC code generation, but 'dedicated' plugins are much easier to use especially for 'simple' cases.
Thanks thats a lot more clear, in that case we should fix the tests
It seems to a problem with naming versions. Missing a better tag git describe
currently names the commits after the forked-from-akka
tag. In some cases, the leading f
seems to be snipped off (maybe because usually the tags are v1.0.0
?) leading to the version starting with orked-from...
which isn't what is expected later on... Maybe most easily we should either create a random tag that has a proper version format or make sure the forked-from-akka
tag isn't seen in the build.
Closing this, everything is clarified and the tests have been fixed
I am missing some context here, but is there a reason why there is a gradle/maven plugin for this project specifically? @jrudolph @raboof Maybe you have some idea?
https://github.com/apache/incubator-pekko-grpc/issues/18 is relevant, because if the gradle plugin is not necessary then we can just remove it and delete the tests.