apache / pekko-grpc

Apache Pekko gRPC

https://pekko.apache.org/

Apache License 2.0

37 stars 16 forks source link

Closed laglangyue closed 2 months ago

laglangyue commented 2 months ago

motivation

close #302 share trailers through matval

remove usage of val trailerPromise = Promise[Metadata]()
use pekko metadata instead of grpc-java metadata
will throw class GrpcServiceException(val status: Status, val metadata: Metadata) extends StatusRuntimeException(status, metadata.raw.orNull) instead of StatusRuntimeException (grpc-java)

Roiocam commented 2 months ago

It seems that you missed the deletion of FIXME comment.

laglangyue commented 2 months ago

It seems that you missed the deletion of FIXME comment.

you mean it in title and description? I have removed it.

Roiocam commented 2 months ago

you mean it in title and description? I have removed it.

In the code mentioned in your ISSUE