apache / pekko-grpc

Apache Pekko gRPC
https://pekko.apache.org/
Apache License 2.0
37 stars 16 forks source link

fail PekkoDiscoveryNameResolver on invalid addresses #333

Open raboof opened 1 week ago

raboof commented 1 week ago

ResolvedTarget has an address: Option[InetAddress]. PekkoDiscoveryNameResolver uses that, even when its .getAddress returns null. It would probably be better to fail early and treat this the same as a target with a host without an address that fails to resolve?

(if we change this we probably need to adapt some tests around balancing to test with 'valid but non-responsive' addresses rather than 'invalid' addresses)