search

apache / pekko-http

The Streaming-first HTTP server/module of Apache Pekko
https://pekko.apache.org/
Apache License 2.0
152 stars 36 forks source link

scala 3.3 merge broke nightly jar publish (scaladoc issue) #157

Closed pjfanning closed 1 year ago

pjfanning commented 1 year ago

see https://github.com/apache/incubator-pekko-http/actions/runs/5090942292/jobs/9151097224

fyi @mdedetrich

may have another cause but the recent merge is likely candidate

I spotted that some of the build params had 'akka' prefixes earlier (including one related to scaladoc diagrams) and was trying to fix that - may be related to this (#155)

mdedetrich commented 1 year ago

@pjfanning Do you want to go ahead and merge https://github.com/apache/incubator-pekko-http/pull/155 then?

pjfanning commented 1 year ago

I still haven't had a chance to do a full analysis of this issue but I think #155 is more likely to help than to make things worse

mdedetrich commented 1 year ago

Okay well just let me know when you want me to look into this

pjfanning commented 1 year ago

@mdedetrich this happens with and without #155

You can reproduce with sbt doc. I don't know why this has started happening now.

mdedetrich commented 1 year ago

Okay I will look at it then

pjfanning commented 1 year ago

One oddity is in project/Doc.scala. The skip-packages is defined twice. Once without the scala version check and then again with the version check.

Edit: while this should be fixed - it isn't what is causing this scaladoc verification issue.

mdedetrich commented 1 year ago

Indeed I think I messed up the merge conflict, trying this out now. Its meant to be org.apache.pekko.pattern

mdedetrich commented 1 year ago

Indeed I think I messed up the merge conflict, trying this out now. Its meant to be org.apache.pekko.pattern

So this solved one problem, there is however another which I am looking into

mdedetrich commented 1 year ago

@pjfanning So this is a bit of a red herring, sbt doc doesn't in general work, whether before or after the scala 3 PR. What you are meant to use instead is sbt unidoc (the difference between doc and unidoc is that it unidoc merges all of the documentation from different projects/packages which is why sbt doc failed).

You can verify this here https://github.com/apache/incubator-pekko-http/blob/c98db6bd9774cef38f3ce33a18731f277a1c5792/.github/workflows/publish.yml#L59

Nonetheless there was cases of dulicated lines/regressions which I will clean up. Feel free to reopen if I missed something.