search

apache / pekko-http

The Streaming-first HTTP server/module of Apache Pekko
https://pekko.apache.org/
Apache License 2.0
149 stars 36 forks source link

Rename package from `akka` to `org.apache.pekko`. #21

Closed mdedetrich closed 1 year ago

mdedetrich commented 1 year ago

We should rename the package from akka to org.apache.pekko. This has somewhat higher priority specifically for this pekko module because we already have non trivial PR's open against it and to respect other peoples time we should finalize the directory structure of the project so that we aren't asking authors of PR's to do major rebase's to resolve merge conflicts against main branch.

Due to pekko-http's usage of private[akka], its not possible to change the packages without some hacky workarounds because in changing the package to org.apache.pekko you can no longer access the private[akka] internal API's. The more principled and easier way to get around this is to change the dependency to use a pekko nightly/snapshot however this is currently blocked by https://github.com/apache/incubator-pekko/issues/107

mdedetrich commented 1 year ago

Due to pekko-http's usage of private[akka], its not possible to change the packages without some hacky workarounds because in changing the package to org.apache.pekko you can no longer access the private[akka] internal API's. The more principled and easier way to get around this is to change the dependency to use a pekko nightly/snapshot however this is currently blocked by https://github.com/apache/incubator-pekko/issues/107

This is no longer the case ever since Pekko was published to Apache's Nexus snapshot repository, I just updated the Akka dependency in Pekko and now things are working as expected.