need to fix issues in source tgz with the linked-dir

apache / pekko-http

The Streaming-first HTTP server/module of Apache Pekko

https://pekko.apache.org/

Apache License 2.0

150 stars 36 forks source link

need to fix issues in source tgz with the linked-dir #444

Closed pjfanning closed 4 months ago

pjfanning commented 7 months ago

We had issues in the last pekko-http release with the linked dir used in testing. Seemed to only affect Windows users then but now, it's affecting Mac users.

x apache-pekko-http-1.0.1-RC1-incubating-src-20240126/http-tests/src/test/resources/dirWithLink/linked-dir: Truncated tar archive
tar: Error exit delayed from previous errors.

same dir that causes the issue in https://github.com/apache/incubator-pekko-http/issues/275

pjfanning commented 7 months ago

I looked at sbt-source-dist and it might be possible to get it some symlinks - but I think we are better off rewriting the FileAndResourceDirectivesSpec so that it creates a temp dir that has all the files and symlinks set up by the test code before we run the main part of the test - i.e. remove the need for the symlink being checked into git and being reproduced in the tgz.