Closed SkyTrix closed 3 months ago
@SkyTrix how long does this test take to run? A couple of seconds is ok but we ideally would not have long running tests.
@SkyTrix how long does this test take to run? A couple of seconds is ok but we ideally would not have long running tests.
This test, like most others in this file, is pretty simple and runs in 5 milliseconds on my machine. This just reads and compares a hex number, there is no 20MB chunk anywhere to worry about.
Maybe the value can be adjusted with the configuration value read from the default configuration, better than hard cording.
This is a followup of #528
The current test goes over the configured max chunk size when parsing the last hex char. The spirit of the code is to continue parsing the size even if we've already gone over the max chunk size. To actually test this we need to make sure another char follows after we've gone over the max chunk size.