search

apache / pekko-management

Apache Pekko Management is a suite of tools for operating Pekko Clusters.
https://pekko.apache.org/
Apache License 2.0
19 stars 12 forks source link

Create HealthCheckSettingsCheck.scala #299

Closed pjfanning closed 6 days ago

pjfanning commented 2 weeks ago

relates to #293 - shows what could be broken if we make the HealthCheckSettingsCheck constructor non-public

I have no objection to making constructors that don't have exactly these 5 params non-public - eg package private - but I think this constructor or its equivalent after #293 should continue to be public.

HealthCheckSettings(
    val readinessChecks: immutable.Seq[NamedHealthCheck],
    val livenessChecks: immutable.Seq[NamedHealthCheck],
    val readinessPath: String,
    val livenessPath: String,
    val checkTimeout: FiniteDuration)
pjfanning commented 2 weeks ago

I'm not sure that this needs to be merged. If we want to merge it, I will need to fix the Scala 2.12 compile issue.