search

apache / pekko-management

Apache Pekko Management is a suite of tools for operating Pekko Clusters.
https://pekko.apache.org/
Apache License 2.0
22 stars 14 forks source link

Configuration option to enable gzip compression on k8s pods api for service discovery #336

Closed thjaeckle closed 1 month ago

thjaeckle commented 1 month ago

Resolves: #335

Feedback is very welcome, I am not very experienced in Scala.

pjfanning commented 1 month ago

There is support for integration testing in the integration-test directory. This includes an existing K8s test. Maybe you could modify this to use gzip.

thjaeckle commented 1 month ago

There is support for integration testing in the integration-test directory. This includes an existing K8s test. Maybe you could modify this to use gzip.

Ah, yes .. I overlooked the integration-tests. There are 2 "kubernetes-api" tests - one for a Scala project and one for a Java/Maven one. I adjusted now the Java/Maven one to ask for gzip compression. This way, still both ways are tested.

thjaeckle commented 1 month ago

@pjfanning could you rerun the failed unit test? Seems like a port conflict..

pjfanning commented 1 month ago

Merged - thanks