search

apache / pekko-persistence-jdbc

Asynchronously writes journal and snapshot entries to configured JDBC databases so that Apache Pekko Actors can recover state
https://pekko.apache.org/
Apache License 2.0
12 stars 16 forks source link

Make DurableState possible to use with other databases #56

Closed zackman0010 closed 6 months ago

zackman0010 commented 1 year ago

I know the first priority is getting the 1.0.0 version out, so this won't be handled for a while, but I figured I'd go ahead and submit this issue so it might could be looked at in the future.

One of the things currently unimplemented even in the original akka-persistence-jdbc is Durable State for any database other than Postgres or H2. This limitation is not even mentioned in the documentation, it just throws errors at runtime if you try to use a different database (Oracle in our case) for Durable State. I'd love to see it finally get fully implemented in Pekko.

pjfanning commented 1 year ago

thanks @zackman0010 - any interest in trying to do a PR yourself?

Would you also help us out by suggesting a doc change that could be made to note this? Somewhere in https://pekko.apache.org/docs/pekko-persistence-jdbc/current/

zackman0010 commented 1 year ago

@pjfanning Normally I would, but I'm currently swamped at work right now and can't take on another side project. If I do get some free time in the future, I might look into it. I will go ahead and find a place to put it in the docs, though.

pjfanning commented 1 year ago

thanks @zackman0010 - if javadoc/scaladoc is the right place to note this, then we can do that. I've never used this module so I'd prefer to get advice from a user about this.

zackman0010 commented 1 year ago

The way these Persistence modules work is that they're essentially plugins, they do the work behind the scenes for the user. The Javadoc/Scaladoc is almost never seen except by power users and developers. So the best place for a note on restrictions would be the documentation, which is the only thing most users see. I'll have PRs submitted shortly for those.

zackman0010 commented 1 year ago

@pjfanning Thanks for merging the docs! Can you reopen this issue? Looks like my comment on the PR made it think it was supposed to close this, lol.