Implement `deleteObject(persistenceId: String, revision: Long)` properly

apache / pekko-persistence-r2dbc

Asynchronously writes journal and snapshot entries to configured R2DBC databases so that Apache Pekko Actors can recover state

https://pekko.apache.org/

Apache License 2.0

13 stars 6 forks source link

Open mdedetrich opened 1 year ago

mdedetrich commented 1 year ago

As discussed in https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/8#discussion_r1158930062, the current implementation of deleteObject(persistenceId: String, revision: Long) just defers to deleteObject(persistenceId: String) (which means it ignores the revision).

The implementation should instead be improved so it only deletes correct revision.

pjfanning commented 10 months ago

@mdedetrich do you want this in 1.0.0?

mdedetrich commented 10 months ago

@mdedetrich do you want this in 1.0.0?

Should go in 1.1.0