search

apache / pekko-persistence-r2dbc

Asynchronously writes journal and snapshot entries to configured R2DBC databases so that Apache Pekko Actors can recover state
https://pekko.apache.org/
Apache License 2.0
14 stars 6 forks source link

Remove SemVer #99

Closed mdedetrich closed 6 months ago

mdedetrich commented 6 months ago

Due to https://github.com/apache/pekko-persistence-r2dbc/issues/90

mdedetrich commented 6 months ago

@pjfanning Should I go ahead and merge this as its related to an issue you are talking about?

pjfanning commented 6 months ago

I'm neutral on this. The change proposed in #90 is not massively impacting but I don't mind if we change the semver setting.

mdedetrich commented 6 months ago

I would like to see https://github.com/apache/pekko-persistence-r2dbc/issues/90 done as it implied there is a legitimate reason why it was changed to Long. I'll merge this when I get home

pjfanning commented 6 months ago

@mdedetrich R2dbcExecutor is documented to be an internal class. For me, this means we can change its return types without too much fanfare.

pjfanning commented 6 months ago

Maybe we should work out how big the changes in https://github.com/apache/pekko-persistence-r2dbc/pull/101 will be before we decide if we need this.

So far the public API changes are only in pekko-projection-r2dbc and not in the pekko-persistence-r2dbc module - maybe we could just remove semver marker from pekko-projection-r2dbc.

mdedetrich commented 6 months ago

Maybe we should work out how big the changes in https://github.com/apache/pekko-persistence-r2dbc/pull/101 will be before we decide if we need this.

So far the public API changes are only in pekko-projection-r2dbc and not in the pekko-persistence-r2dbc module - maybe we could just remove semver marker from pekko-projection-r2dbc.

Sure, do you want to go ahead with the PR to find out?

gstein commented 6 months ago

I removed myself as a reviewer. That was uncool @mdedetrich.

mdedetrich commented 6 months ago

I removed myself as a reviewer. That was uncool @mdedetrich.

Apologies, this was an accident as there is another greg as part of committers.