search

apache / pekko-platform-guide

Examples how to implement Microservices using Apache Pekko
https://pekko.apache.org/
Apache License 2.0
4 stars 6 forks source link

migrate cleanup-dependencies-project to pekko #57

Closed laglangyue closed 8 months ago

laglangyue commented 8 months ago

This pr includes:

migrate cleanup-dependencies-project to pekko

Motivation:

it is a subtask of migrating akka to pekko. Migrating Pekko from Akka at once will result in many changes and cause trouble for reviewers

Test:

test localy，there still some problems

laglangyue commented 8 months ago

I didn't find a sbt-pekko-grpc

// tag::remove-grpc-plugin[]
addSbtPlugin("com.lightbend.akka.grpc" % "sbt-akka-grpc" % "2.1.5")
// end::remove-grpc-plugin[]
pjfanning commented 8 months ago

I didn't find a sbt-pekko-grpc

// tag::remove-grpc-plugin[]
addSbtPlugin("com.lightbend.akka.grpc" % "sbt-akka-grpc" % "2.1.5")
// end::remove-grpc-plugin[]

Use

addSbtPlugin("org.apache.pekko" % "pekko-grpc-sbt-plugin" % "1.0.1")
laglangyue commented 8 months ago

1.0.1 of pekko-grpc-sbt-plugin will cause conflict and 1.0.0 is ok

[error] (update) found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error] 
[error]     * org.scala-lang.modules:scala-xml_2.12:2.2.0 (early-semver) is selected over 1.1.1
[error]         +- com.typesafe.play:twirl-api_2.12:1.6.1             (depends on 2.2.0)
[error]         +- com.typesafe.sbt:sbt-native-packager:1.8.1 (sbtVersion=1.0, scalaVersion=2.12) (depends on 1.1.1)
pjfanning commented 8 months ago

1.0.1 of pekko-grpc-sbt-plugin will cause conflict and 1.0.0 is ok

[error] (update) found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error] 
[error]   * org.scala-lang.modules:scala-xml_2.12:2.2.0 (early-semver) is selected over 1.1.1
[error]       +- com.typesafe.play:twirl-api_2.12:1.6.1             (depends on 2.2.0)
[error]       +- com.typesafe.sbt:sbt-native-packager:1.8.1 (sbtVersion=1.0, scalaVersion=2.12) (depends on 1.1.1)

I added https://github.com/apache/incubator-pekko-platform-guide/pull/57/commits/23c29bf4c28906ab9811b2eb8aeadc5e430289a7 - we've had to do that in other builds too

laglangyue commented 8 months ago

1.0.1 of pekko-grpc-sbt-plugin will cause conflict and 1.0.0 is ok

[error] (update) found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error] 
[error]     * org.scala-lang.modules:scala-xml_2.12:2.2.0 (early-semver) is selected over 1.1.1
[error]         +- com.typesafe.play:twirl-api_2.12:1.6.1             (depends on 2.2.0)
[error]         +- com.typesafe.sbt:sbt-native-packager:1.8.1 (sbtVersion=1.0, scalaVersion=2.12) (depends on 1.1.1)

I added 23c29bf - we've had to do that in other builds too

should we use this,sbt-native-packager maybe remove to it,but not com.typesafe.sbt addSbtPlugin("com.github.sbt" % "sbt-native-packager" % "1.9.16")

laglangyue commented 8 months ago

yeah, sbt-native-packager was migrated to // https://mvnrepository.com/artifact/com.github.sbt/sbt-native-packager_2.12_1.0 libraryDependencies += "com.github.sbt" % "sbt-native-packager_2.12_1.0" % "1.9.16" this is rep https://github.com/sbt/sbt-native-packager

laglangyue commented 8 months ago

Please trigger the workflow @pjfanning PTAL, waitting for CI. I would away from my compute and go home.If there are still any problems, I will handle them tomorrow.