apache / pekko

Build highly concurrent, distributed, and resilient message-driven applications using Java/Scala
https://pekko.apache.org/
Apache License 2.0
1.2k stars 148 forks source link

ActorSystem start code has ref to Akka #115

Closed pjfanning closed 1 year ago

pjfanning commented 1 year ago
ManifestInfo(this).checkSameVersion("Akka", allModules, logWarning = true)

Need to work out what to replace this with

kw217 commented 1 year ago

As far as I can see this $productName is just used in the error string "You are using version $highestVersion of $productName, but...", so we can safely change all occurrences to "Pekko".

https://github.com/apache/incubator-pekko/blob/4ac0f00a477873965ee7d52e16faefb1de91fe3a/actor/src/main/scala/org/apache/pekko/util/ManifestInfo.scala#L102

kw217 commented 1 year ago

Though this does raise the question of what "older" means. Do we plan to release Pekko at 1.0.0 or 2.6.x? If the former, we will need to tweak code like this to be a bit smarter.

pjfanning commented 1 year ago

Though this does raise the question of what "older" means. Do we plan to release Pekko at 1.0.0 or 2.6.x? If the former, we will need to tweak code like this to be a bit smarter.

It will be pekko 1.0.0. Why does this matter? Pekko versions will go up - pekko and akka are unrelated - different packages and jars - if someone has akka and pekko on their classpath, they should not interfere with each other.

kw217 commented 1 year ago

Ah good point - in which case you'll want to remove most of the content of this list then:

https://github.com/apache/incubator-pekko/blob/main/actor/src/main/scala/org/apache/pekko/util/ManifestInfo.scala#L46

pjfanning commented 1 year ago

this is done