search

apache / pekko

Build highly concurrent, distributed, and resilient message-driven applications using Java/Scala
https://pekko.apache.org/
Apache License 2.0
1.17k stars 140 forks source link

fix: flaky logging mdc tests #1410

Closed Roiocam closed 1 month ago

Roiocam commented 1 month ago

Resolves: https://github.com/apache/pekko/issues/795, diagnostics: https://github.com/apache/pekko/issues/795#issuecomment-2244124743

ci checks passed in my repo:

laglangyue commented 1 month ago

lgtm

Roiocam commented 1 month ago

let us merge, and then we will see what happens

pjfanning commented 1 month ago

@Roiocam can you backport this change to 1.0.x branch?

Roiocam commented 1 month ago

@Roiocam can you backport this change to 1.0.x branch?

they looks cool in 1.0.x

pjfanning commented 1 month ago

I thought the test was flaky in 1.0.x - but not failing as often as in the main branch. Let me keep an eye on the 1.0.x builds. This test did not fail there last night. I'm going to try to backport some other changes to 1.0.x for other broken tests first.