search

apache / pekko

Build highly concurrent, distributed, and resilient message-driven applications using Java/Scala
https://pekko.apache.org/
Apache License 2.0
1.2k stars 148 forks source link

jdk9 tests do not run #1433

Closed pjfanning closed 2 months ago

pjfanning commented 2 months ago

See https://github.com/apache/pekko/pull/1432 - I deliberately modified 2 classes (1 Java, 1 Scala) to see if they were even compiled. The PR did fail because scalafmt and the doc build failed but the main part of the build where we compile code and run tests - this all ran ok.

Roiocam commented 2 months ago

I guess sbt dependWalkerCheck didn't want to verify TestJDK9+ classes compile, but I don't remember why it was on purpose.

and it is normal that PRValidationTest does not run JDK9 verification. We will not verify these on the main process, but only verify on binary compability or documentation check

pjfanning commented 2 months ago

1434 merged