search

apache / pekko

Build highly concurrent, distributed, and resilient message-driven applications using Java/Scala
https://pekko.apache.org/
Apache License 2.0
1.2k stars 148 forks source link

investigate unusual header on Bench.scala #157

Closed pjfanning closed 1 year ago

pjfanning commented 1 year ago

https://github.com/apache/incubator-pekko/blob/main/actor-tests/src/test/scala/org/apache/pekko/actor/Bench.scala

/* The Computer Language Benchmarks Game
   http://shootout.alioth.debian.org/
   contributed by Julien Gaugaz
   inspired by the version contributed by Yura Taras and modified by Isaac Gouy
 */

Doesn't appear to assert a copyright or a license.

We can keep it but maybe don't need to.

If it is decided that this does assert a copyright and/or a license, we may need to update the LICENSE or NOTICE for this repo.

If this is not a valid copyright and/or license - then we should remove the check in project/CopyrightHeader.scala

justinmclean commented 1 year ago

Hi,

You do need to know how it is licensed. Looks to be this? Although the names are different.

https://salsa.debian.org/benchmarksgame-team/archive-alioth-benchmarksgame/-/blob/master/LICENSE.md https://salsa.debian.org/benchmarksgame-team/archive-alioth-benchmarksgame/-/blob/master/LICENSE.md

Justin

On 10 Feb 2023, at 7:18 am, PJ Fanning @.***> wrote:

https://github.com/apache/incubator-pekko/blob/main/actor-tests/src/test/scala/org/apache/pekko/actor/Bench.scala https://github.com/apache/incubator-pekko/blob/main/actor-tests/src/test/scala/org/apache/pekko/actor/Bench.scala / The Computer Language Benchmarks Game http://shootout.alioth.debian.org/ contributed by Julien Gaugaz inspired by the version contributed by Yura Taras and modified by Isaac Gouy / Doesn't appear to assert a copyright or a license.

We can keep it but maybe don't need to.

If it is decided that this does assert a copyright and/or a license, we may need to update the LICENSE or NOTICE for this repo.

— Reply to this email directly, view it on GitHub https://github.com/apache/incubator-pekko/issues/157, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDI6DZUPFRSXEGIFDHVHLWWVGKXANCNFSM6AAAAAAUW7XTUQ. You are receiving this because you are subscribed to this thread.

jrudolph commented 1 year ago

If in doubt, it would probably also ok to just remove it, it's just benchmark code.

pjfanning commented 1 year ago

it is basically https://salsa.debian.org/benchmarksgame-team/archive-alioth-benchmarksgame/-/blob/master/contributed-source-code/shootout/chameneos/chameneos.scala-2.scala

I suspect removing this benchmark test might be the best way forward.

justinmclean commented 1 year ago

The license is compatible with the Apache license you could leave it in and add that information to LICENSE

pjfanning commented 1 year ago

I'm running a build, it so far looks like that file is not even used.

jrudolph commented 1 year ago

Fixed by removing the file in #171.