search

apache / pekko

Build highly concurrent, distributed, and resilient message-driven applications using Java/Scala
https://pekko.apache.org/
Apache License 2.0
1.22k stars 148 forks source link

Remove explicit handling of `java8Home` entirely in Pekko sbt build #259

Open mdedetrich opened 1 year ago

mdedetrich commented 1 year ago

With a result of the changes in https://github.com/apache/incubator-pekko/pull/258 that removes the -release/-target workaround it appears that all of this special case handling for JDK 1.8 in Pekko (i.e. https://github.com/apache/incubator-pekko/blob/main/project/JdkOptions.scala#L26 and all of the relevant places where its referenced) is no longer necessary.

mdedetrich commented 1 year ago

Closing this for now because its still needed, see https://github.com/apache/incubator-pekko/pull/258#discussion_r1143532066

mdedetrich commented 1 year ago

Re-opening this

mdedetrich commented 1 year ago

Blocked by https://github.com/apache/incubator-pekko/issues/262