search

apache / pekko

Build highly concurrent, distributed, and resilient message-driven applications using Java/Scala
https://pekko.apache.org/
Apache License 2.0
1.22k stars 148 forks source link

Make org.apache.pekko.actor.AbstractActor#preRestart final #526

Open He-Pin opened 1 year ago

He-Pin commented 1 year ago

TODO In Pekko 1.1.0, we can remove deprecation and make the method final

  // TODO In Pekko 1.1.0, we can remove deprecation and make the method final
  @deprecated("Override preRestart with message parameter with Optional type instead", "Akka 2.5.0")
  @throws(classOf[Exception])
  @nowarn("msg=deprecated")
  override def preRestart(reason: Throwable, message: Option[Any]): Unit = {
    import pekko.util.OptionConverters._
    preRestart(reason, message.toJava)
  }
pjfanning commented 1 year ago

@He-Pin why not remove it altogether?

He-Pin commented 1 year ago

@pjfanning That's an option too.