Open abhioncbr opened 3 months ago
Attention: Patch coverage is 86.36364%
with 9 lines
in your changes are missing coverage. Please review.
Project coverage is 62.16%. Comparing base (
59551e4
) to head (fbd5450
). Report is 522 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can we add a test to ensure it can read the old format properly? We can put a old format file into the resource folder, and use the new reader to read it
Added the required tests.
@Jackie-Jiang / @klsince, any further comments on the implementation side. I am going to start work on it's usage based on the cluster configuration or table configuration.
Based on the offline discussion, we decided to have pair of separate custom segment metadata reader/writer. We will decide to use custom reader/writer based on the version of the segment metadata.
@Jackie-Jiang / @klsince, please review it once more. Thanks
This is the first set of changes for the issue.
In this PR, we introduce a new custom property reader for the segment metadata files. This custom property reader is based on the commons-configuration2 custom property reader/writer(here is the link). We are introducing this custom property reader to avoid unescaping operation happen for the key in default implementation.
cc: @klsince @Jackie-Jiang @itschrispeck