Closed tibrewalpratik17 closed 2 weeks ago
Attention: Patch coverage is 33.33333%
with 36 lines
in your changes are missing coverage. Please review.
Project coverage is 62.23%. Comparing base (
59551e4
) to head (d67f21c
). Report is 458 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cc @ankitsultana @Jackie-Jiang @snleee can you please help review?
Thanks @ankitsultana for the review! Addressed your comments.
Have the docs been updated @tibrewalpratik17 ?
Thanks @npawar for the reminder! I will update the docs with all the PRs you tagged me on.
label:
feature
release-notes
Resolves #12458. See the linked issue for more details.
This patch allows minion nodes to download segments from servers rather than only relying on deepstore copy. This is behind a task-level config:
allowDownloadFromServer
(default value is false).Tested in our cluster by removing deepstore copies explicitly and enabling this config. We were able to successfully compact a segment post this config.