apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.17k stars 1.21k forks source link

[HELM] Allow statefulsets to automatically roll when updating configmaps #13046

Closed nilaprasad closed 2 days ago

nilaprasad commented 2 weeks ago

Background

Currently, the helm charts don't roll the corresponding pods for a given statefulset when an associated configmap is updated and it needs to be done manually. This can lead to issues where the expected configuration for an environment differs from what's actually there. To allow for quicker iterations on the configuration the helm charts should support automatic rolling of the statefulsets.

Proposed Solution

Allow for an optional annotation that uses helm's ability to automatically roll deployments. For example, this can be set under the controller annotations here.

templates/controller/statefulset.yaml

      ...
      annotations:
        {{- if .Values.controller.automaticReload.enabled }}
        checksum/config: {{ include (print $.Template.BasePath "<configmap-dir>") . | sha256sum }}
{{ toYaml .Values.controller.podAnnotations | indent 8 }}

values.yaml

...
controller:
  ...
  automaticReload:
    enabled: true
  ...
abhioncbr commented 2 weeks ago

Looking into it.

abhioncbr commented 3 days ago

We can close this issue. Thanks