apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.17k stars 1.21k forks source link

Do not automatically execute queries in the URL #13055

Open jadami10 opened 2 weeks ago

jadami10 commented 2 weeks ago

8194 added the ability to pass URLs with queries around. And when someone else clicks the URL, the query is automatically populated in the sql editor and executed.

The issue here is, it's pretty common for someone to say "hey, can you help me with this < link to expensive query that takes down a server >?" And suddenly, you have a link in the wild that will slow or take down Pinot every time it's clicked even if they just wanted to see the query.

The proposal is to, by default, disable automatically running queries via URL (including back/forward buttons)

jadami10 commented 2 weeks ago

cc @Jackie-Jiang @xiangfu0 since you reviewed the initial feature

Jackie-Jiang commented 2 weeks ago

I guess this is a UI feature, where we just want to fill the query from URL to the query console but not execute it? cc @jayeshchoudhary to also comment on this