Closed Jackie-Jiang closed 13 hours ago
Attention: Patch coverage is 35.97884%
with 121 lines
in your changes are missing coverage. Please review.
Project coverage is 62.13%. Comparing base (
59551e4
) to head (3182f6e
). Report is 420 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In #11763 we have added support to server to support both INT and FLOAT literal. After one release (release 1.1), now we can move forward to send INT and FLOAT from broker side.
This PR also contains type related fixes and cleanups:
Literal.getFieldValue()
because the field stored in thrift doesn't always reflect the actual Pinot value. Replaced with newly introduced helper functions inRequestUtils
Backward Incompatible
This PR can cause incompatibility for the new added
VECTOR_SIMILARITY
function during upgrade. But since this feature is newly added and not in production, we won't wait another release to fix it