apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.17k stars 1.21k forks source link

SQL compliance: allow INT and FLOAT literal #13078

Closed Jackie-Jiang closed 13 hours ago

Jackie-Jiang commented 2 weeks ago

In #11763 we have added support to server to support both INT and FLOAT literal. After one release (release 1.1), now we can move forward to send INT and FLOAT from broker side.

This PR also contains type related fixes and cleanups:

Backward Incompatible

This PR can cause incompatibility for the new added VECTOR_SIMILARITY function during upgrade. But since this feature is newly added and not in production, we won't wait another release to fix it

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 35.97884% with 121 lines in your changes are missing coverage. Please review.

Project coverage is 62.13%. Comparing base (59551e4) to head (3182f6e). Report is 420 commits behind head on master.

Files Patch % Lines
...ot/common/request/context/RequestContextUtils.java 2.12% 46 Missing :warning:
...pache/pinot/common/utils/request/RequestUtils.java 33.33% 40 Missing and 4 partials :warning:
...optimizer/filter/TimePredicateFilterOptimizer.java 66.66% 6 Missing and 3 partials :warning:
...ery/optimizer/filter/NumericalFilterOptimizer.java 0.00% 6 Missing :warning:
.../org/apache/pinot/spi/data/DateTimeFormatSpec.java 20.00% 3 Missing and 1 partial :warning:
...roker/requesthandler/BaseBrokerRequestHandler.java 25.00% 3 Missing :warning:
...roker/routing/segmentpruner/TimeSegmentPruner.java 72.72% 2 Missing and 1 partial :warning:
...apache/pinot/sql/parsers/rewriter/ClpRewriter.java 50.00% 1 Missing and 1 partial :warning:
...he/pinot/sql/parsers/rewriter/OrdinalsUpdater.java 90.00% 0 Missing and 1 partial :warning:
...izer/filter/IdenticalPredicateFilterOptimizer.java 50.00% 0 Missing and 1 partial :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #13078 +/- ## ============================================ + Coverage 61.75% 62.13% +0.38% + Complexity 207 198 -9 ============================================ Files 2436 2514 +78 Lines 133233 137871 +4638 Branches 20636 21328 +692 ============================================ + Hits 82274 85673 +3399 - Misses 44911 45790 +879 - Partials 6048 6408 +360 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/13078/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/13078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `<0.01% <0.00%> (-0.01%)` | :arrow_down: | | [integration](https://app.codecov.io/gh/apache/pinot/pull/13078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `<0.01% <0.00%> (-0.01%)` | :arrow_down: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/13078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `<0.01% <0.00%> (-0.01%)` | :arrow_down: | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/13078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/13078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.10% <35.97%> (+0.39%)` | :arrow_up: | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/13078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.02% <35.97%> (+0.40%)` | :arrow_up: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/13078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.12% <35.97%> (+0.38%)` | :arrow_up: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/13078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.00% <35.97%> (+34.28%)` | :arrow_up: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/13078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.13% <35.97%> (+0.38%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/13078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.13% <35.97%> (+0.38%)` | :arrow_up: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/13078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.80% <33.90%> (-0.09%)` | :arrow_down: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/13078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.74% <4.76%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.