Open deepthi912 opened 1 week ago
Attention: Patch coverage is 50.81967%
with 30 lines
in your changes are missing coverage. Please review.
Project coverage is 62.18%. Comparing base (
59551e4
) to head (0e02293
). Report is 433 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Sure, I wanted to do that too. Will look and see where I can improve further
@Jackie-Jiang I noticed that registery, pipeline have static methods which are used by some of the classes. These static methods are calling RecordEnricherFactory which is again implemented by function and clp Enricher classes. I tried to check if I could squeeze in anywhere but no right spot. Not sure if by just removing RecordEnricher, we can make any big difference in refactoring though.
Basically the idea is to re-do #12243 and integrate CLP transform as a RecordTransformer
1) Removed RecordEnricher 2) Changed the package of pipeline, factory and Config of RecordEnricher to "org.apache.pinot.plugin.record.enricher" 3) Used transform in RecordTransformer to serve the purpose of enrich in RecordEnricher.