Closed andimiller closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 62.25%. Comparing base (
59551e4
) to head (b2dfe14
). Report is 470 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the contribution.
In general, one comment from K8s before v1.21 support, and to give other users better control over the PDB, can we have a boolean property say enabled
to make the PDB optional?
Thanks for the contribution.
In general, one comment from K8s before v1.21 support, and to give other users better control over the PDB, can we have a boolean property say
enabled
to make the PDB optional?
Sure, done, and since the default replica counts of everything in values.yaml is 1 I've defaulted it to off
cc @xiangfu0 @zhtaoxiang
FYI, the zookeeper chart from bitnami (the one we depend on) also has this ability.
FYI, the zookeeper chart from bitnami (the one we depend on) also has this ability.
I'll adjust this to work with the same config settings as the zookeeper chart then, if people are already familiar with that one
FYI, the zookeeper chart from bitnami (the one we depend on) also has this ability.
I've adjusted this to be closer how to the zookeeper chart works, with pdb
as the config name, and exposing both minAvailable
and maxUnavailable
I've set these by default at allowing 50% of the servers/brokers/controllers to be unavailable, and exposed these settings in the configuration so the user can change them.
These prevent outages when the underlying kuberenetes cluster undergoes an upgrade.
You might configure these like so in your helm yaml settings: