Closed chrajeshbabu closed 4 days ago
Attention: Patch coverage is 75.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 63.81%. Comparing base (
59551e4
) to head (e5ef21f
). Report is 1342 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
.../org/apache/pinot/plugin/filesystem/S3PinotFS.java | 75.00% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the PR. Would you please add description section with details?
Thanks for the PR. Would you please add description section with details?
Thank you @mayankshriv for review. Added the description.
Thanks @chrajeshbabu !
Could you please add a section of Release Notes
to this PR description?
Thank you merging it @xiangfu0. @mayankshriv for review.
Will add the release notes.
The List files API in S3PinotFS builds file paths from S3 objects using a hardcoded S3 scheme. This prevents the use of s3a compatible storages, even though the server or controller can configure s3a as a protocol mapped to S3PinotFS.
The List files API should dynamically determine the scheme based on the file location provided.