apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.53k stars 1.29k forks source link

Support for S3A Connector #14312 #14474

Closed chrajeshbabu closed 4 days ago

chrajeshbabu commented 1 week ago

The List files API in S3PinotFS builds file paths from S3 objects using a hardcoded S3 scheme. This prevents the use of s3a compatible storages, even though the server or controller can configure s3a as a protocol mapped to S3PinotFS.

The List files API should dynamically determine the scheme based on the file location provided.

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.81%. Comparing base (59551e4) to head (e5ef21f). Report is 1342 commits behind head on master.

Files with missing lines Patch % Lines
.../org/apache/pinot/plugin/filesystem/S3PinotFS.java 75.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #14474 +/- ## ============================================ + Coverage 61.75% 63.81% +2.06% - Complexity 207 1570 +1363 ============================================ Files 2436 2663 +227 Lines 133233 146205 +12972 Branches 20636 22405 +1769 ============================================ + Hits 82274 93305 +11031 - Misses 44911 46015 +1104 - Partials 6048 6885 +837 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/14474/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/14474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/apache/pinot/pull/14474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/14474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/14474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/14474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.78% <75.00%> (+2.07%)` | :arrow_up: | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/14474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.69% <75.00%> (+2.06%)` | :arrow_up: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/14474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.80% <75.00%> (+2.06%)` | :arrow_up: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/14474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.65% <75.00%> (+35.93%)` | :arrow_up: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/14474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.81% <75.00%> (+2.06%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/14474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.81% <75.00%> (+2.06%)` | :arrow_up: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/14474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.56% <ø> (+8.67%)` | :arrow_up: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/14474/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.13% <75.00%> (+6.40%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mayankshriv commented 6 days ago

Thanks for the PR. Would you please add description section with details?

chrajeshbabu commented 5 days ago

Thanks for the PR. Would you please add description section with details?

Thank you @mayankshriv for review. Added the description.

xiangfu0 commented 4 days ago

Thanks @chrajeshbabu !

Could you please add a section of Release Notes to this PR description?

chrajeshbabu commented 1 day ago

Thank you merging it @xiangfu0. @mayankshriv for review.

Will add the release notes.