apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.52k stars 1.29k forks source link

Add TLS support to mailboxes used in the multi-stage engine #14476

Closed yashmayya closed 3 days ago

yashmayya commented 4 days ago
codecov-commenter commented 4 days ago

Codecov Report

Attention: Patch coverage is 42.10526% with 33 lines in your changes missing coverage. Please review.

Project coverage is 63.81%. Comparing base (59551e4) to head (992dd99). Report is 1343 commits behind head on master.

Files with missing lines Patch % Lines
...pache/pinot/common/utils/grpc/GrpcQueryClient.java 0.00% 11 Missing :warning:
...he/pinot/query/mailbox/channel/ChannelManager.java 56.25% 6 Missing and 1 partial :warning:
...pinot/query/mailbox/channel/GrpcMailboxServer.java 46.15% 6 Missing and 1 partial :warning:
...che/pinot/core/transport/grpc/GrpcQueryServer.java 0.00% 5 Missing :warning:
...requesthandler/MultiStageBrokerRequestHandler.java 66.66% 0 Missing and 1 partial :warning:
...apache/pinot/query/service/server/QueryServer.java 0.00% 1 Missing :warning:
.../apache/pinot/server/worker/WorkerQueryServer.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #14476 +/- ## ============================================ + Coverage 61.75% 63.81% +2.06% - Complexity 207 1567 +1360 ============================================ Files 2436 2663 +227 Lines 133233 146225 +12992 Branches 20636 22404 +1768 ============================================ + Hits 82274 93313 +11039 - Misses 44911 46022 +1111 - Partials 6048 6890 +842 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/14476/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/14476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/apache/pinot/pull/14476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/14476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/14476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/14476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.76% <42.10%> (+2.05%)` | :arrow_up: | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/14476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.68% <42.10%> (+2.06%)` | :arrow_up: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/14476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.78% <42.10%> (+2.04%)` | :arrow_up: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/14476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.66% <42.10%> (+35.93%)` | :arrow_up: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/14476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.81% <42.10%> (+2.06%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/14476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.81% <42.10%> (+2.06%)` | :arrow_up: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/14476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.57% <41.50%> (+8.68%)` | :arrow_up: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/14476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.12% <29.82%> (+6.39%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.