Open tibrewalpratik17 opened 4 days ago
Attention: Patch coverage is 11.37931%
with 257 lines
in your changes missing coverage. Please review.
Project coverage is 63.67%. Comparing base (
59551e4
) to head (64cd7d6
). Report is 1358 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Marking it ready for review for early feedback!
PR related to the PEP request: #14305
Here, we are adding a new minion task to merge small segments in an upsert table. More implementation details in the design doc of the linked issue.
Test plan: Enabled this in one of infinite retention tables in Uber. The tables had ~35k segments initially and after enabling this task for ~2 days we were able to reach ~2k segments. The curve also flattens post reaching ~2k segments. We are using the default configs of this task and the table is generating ~500 segments daily. See attached screenshot.
Few details: