search

apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.53k stars 1.29k forks source link

Add Support to add prefix/suffix to Tasks #14478

Closed aishikbh closed 1 week ago

aishikbh commented 1 week ago

Issue

Currently there is no way to add custom prefix/suffix to task names. It can be useful to have the support to add prefix/suffix support for the tasks.

Changes

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.81%. Comparing base (59551e4) to head (1808a98). Report is 1343 commits behind head on master.

Files with missing lines Patch % Lines
...lix/core/minion/PinotHelixTaskResourceManager.java 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #14478 +/- ## ============================================ + Coverage 61.75% 63.81% +2.06% - Complexity 207 1565 +1358 ============================================ Files 2436 2663 +227 Lines 133233 146206 +12973 Branches 20636 22403 +1767 ============================================ + Hits 82274 93306 +11032 - Misses 44911 46008 +1097 - Partials 6048 6892 +844 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/14478/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/14478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/apache/pinot/pull/14478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/14478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/14478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/14478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.76% <0.00%> (+2.05%)` | :arrow_up: | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/14478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.71% <0.00%> (+2.08%)` | :arrow_up: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/14478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.79% <0.00%> (+2.04%)` | :arrow_up: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/14478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.67% <0.00%> (+35.94%)` | :arrow_up: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/14478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.81% <0.00%> (+2.06%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/14478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.81% <0.00%> (+2.06%)` | :arrow_up: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/14478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.57% <ø> (+8.68%)` | :arrow_up: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/14478/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.12% <0.00%> (+6.39%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.