apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.53k stars 1.29k forks source link

Allow reload for UploadedRealtimeSegmentName segments #14494

Closed tibrewalpratik17 closed 4 days ago

tibrewalpratik17 commented 6 days ago

Currently, extracting table type from segment name assumes that the realtime segment is of LLC naming convention. We have added UploadedRealtimeSegmentName naming convention for realtime segments as well. A small patch to allow table type extraction for UploadedRealtimeSegmentName segments as well. This flow is used during reload and delete segment processes. Previously it was resulting in TableNotFoundException.

codecov-commenter commented 6 days ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.75%. Comparing base (59551e4) to head (ef0f5ed). Report is 1358 commits behind head on master.

Files with missing lines Patch % Lines
...ler/api/resources/PinotSegmentRestletResource.java 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #14494 +/- ## ============================================ + Coverage 61.75% 63.75% +2.00% - Complexity 207 1566 +1359 ============================================ Files 2436 2667 +231 Lines 133233 146444 +13211 Branches 20636 22468 +1832 ============================================ + Hits 82274 93364 +11090 - Misses 44911 46157 +1246 - Partials 6048 6923 +875 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/14494/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/14494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/apache/pinot/pull/14494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/14494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/14494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/14494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.73% <0.00%> (+2.02%)` | :arrow_up: | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/14494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.63% <0.00%> (+2.01%)` | :arrow_up: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/14494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.74% <0.00%> (+1.99%)` | :arrow_up: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/14494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.61% <0.00%> (+35.89%)` | :arrow_up: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/14494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.75% <0.00%> (+2.00%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/14494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.74% <0.00%> (+2.00%)` | :arrow_up: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/14494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.52% <ø> (+8.63%)` | :arrow_up: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/14494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.06% <0.00%> (+6.33%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

tibrewalpratik17 commented 6 days ago

Tagging @klsince and @rohityadav1993 as they have relevant context on naming here.