apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.53k stars 1.29k forks source link

Retain boolean type from CLPLogRecordExtractor decoder. #14497

Closed jackluo923 closed 5 days ago

jackluo923 commented 6 days ago

This PR updates the behavior of CLPLogRecordExtractor to prevent Boolean fields from being cast to the string type. Searching for Boolean values in a string column can be confusing, particularly for users accustomed to different programming languages. For instance, Python uses True, while Java uses true, leading to potential inconsistencies.

codecov-commenter commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.76%. Comparing base (59551e4) to head (91059cd). Report is 1361 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #14497 +/- ## ============================================ + Coverage 61.75% 63.76% +2.01% - Complexity 207 1566 +1359 ============================================ Files 2436 2668 +232 Lines 133233 146470 +13237 Branches 20636 22467 +1831 ============================================ + Hits 82274 93399 +11125 - Misses 44911 46149 +1238 - Partials 6048 6922 +874 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/14497/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/14497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/apache/pinot/pull/14497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/14497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/14497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/14497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.73% <ø> (+2.02%)` | :arrow_up: | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/14497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.64% <ø> (+2.01%)` | :arrow_up: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/14497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.75% <ø> (+2.00%)` | :arrow_up: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/14497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.61% <ø> (+35.88%)` | :arrow_up: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/14497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.76% <ø> (+2.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/14497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.76% <ø> (+2.01%)` | :arrow_up: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/14497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.55% <ø> (+8.66%)` | :arrow_up: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/14497/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.06% <ø> (+6.33%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: