search

apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.53k stars 1.29k forks source link

Update NUMBER_TASKS_EXECUTED meter only after task execution is done #14515

Closed shounakmk219 closed 4 days ago

shounakmk219 commented 4 days ago

Right now the meter is incremented at start of task execution hence the sum of other task state metrics does not add up to the executed state metric during an ongoing task execution.

codecov-commenter commented 4 days ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (59551e4) to head (74e5a8a). Report is 1371 commits behind head on master.

Files with missing lines Patch % Lines
.../pinot/minion/taskfactory/TaskFactoryRegistry.java 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #14515 +/- ## ============================================ + Coverage 61.75% 63.83% +2.07% - Complexity 207 1570 +1363 ============================================ Files 2436 2672 +236 Lines 133233 146680 +13447 Branches 20636 22492 +1856 ============================================ + Hits 82274 93628 +11354 - Misses 44911 46128 +1217 - Partials 6048 6924 +876 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/14515/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/14515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/apache/pinot/pull/14515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/14515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/14515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/14515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.82% <0.00%> (+2.11%)` | :arrow_up: | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/14515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.72% <0.00%> (+2.10%)` | :arrow_up: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/14515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.82% <0.00%> (+2.08%)` | :arrow_up: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/14515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.71% <0.00%> (+35.98%)` | :arrow_up: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/14515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.83% <0.00%> (+2.07%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/14515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.82% <0.00%> (+2.07%)` | :arrow_up: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/14515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.51% <ø> (+8.62%)` | :arrow_up: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/14515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.56% <0.00%> (+6.83%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: