search

apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.53k stars 1.29k forks source link

improve error for schema name validation #14517

Closed rohityadav1993 closed 4 days ago

rohityadav1993 commented 4 days ago

refactor

Addresses: https://github.com/apache/pinot/pull/14511#discussion_r1852664946

codecov-commenter commented 4 days ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.88%. Comparing base (59551e4) to head (c01f5dd). Report is 1378 commits behind head on master.

Files with missing lines Patch % Lines
...ller/api/resources/PinotSchemaRestletResource.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #14517 +/- ## ============================================ + Coverage 61.75% 63.88% +2.13% - Complexity 207 1570 +1363 ============================================ Files 2436 2673 +237 Lines 133233 146784 +13551 Branches 20636 22509 +1873 ============================================ + Hits 82274 93770 +11496 - Misses 44911 46096 +1185 - Partials 6048 6918 +870 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/14517/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/14517/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/apache/pinot/pull/14517/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/14517/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/14517/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/14517/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.83% <0.00%> (+2.12%)` | :arrow_up: | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/14517/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.75% <0.00%> (+2.13%)` | :arrow_up: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/14517/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.85% <0.00%> (+2.10%)` | :arrow_up: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/14517/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.73% <0.00%> (+36.01%)` | :arrow_up: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/14517/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.88% <0.00%> (+2.13%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/14517/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.87% <0.00%> (+2.13%)` | :arrow_up: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/14517/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.57% <ø> (+8.68%)` | :arrow_up: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/14517/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.57% <0.00%> (+6.84%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: