search

apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.52k stars 1.29k forks source link

[WIP] Minion task observability refactors #14521

Open shounakmk219 opened 9 hours ago

codecov-commenter commented 9 hours ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 63.85%. Comparing base (59551e4) to head (2474071). Report is 1383 commits behind head on master.

Files with missing lines Patch % Lines
...not/minion/event/EventObserverFactoryRegistry.java 0.00% 4 Missing :warning:
...ava/org/apache/pinot/minion/BaseMinionStarter.java 0.00% 3 Missing :warning:
...inion/event/BaseMinionProgressObserverFactory.java 0.00% 1 Missing :warning:
...inion/event/DefaultMinionEventObserverFactory.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #14521 +/- ## ============================================ + Coverage 61.75% 63.85% +2.10% - Complexity 207 1568 +1361 ============================================ Files 2436 2673 +237 Lines 133233 146792 +13559 Branches 20636 22510 +1874 ============================================ + Hits 82274 93732 +11458 - Misses 44911 46132 +1221 - Partials 6048 6928 +880 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/14521/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/14521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration](https://app.codecov.io/gh/apache/pinot/pull/14521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/14521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+99.99%)` | :arrow_up: | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/14521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | | [java-11](https://app.codecov.io/gh/apache/pinot/pull/14521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.81% <0.00%> (+2.10%)` | :arrow_up: | | [java-21](https://app.codecov.io/gh/apache/pinot/pull/14521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.74% <0.00%> (+2.12%)` | :arrow_up: | | [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/14521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.85% <0.00%> (+2.10%)` | :arrow_up: | | [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/14521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.72% <0.00%> (+35.99%)` | :arrow_up: | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/14521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.85% <0.00%> (+2.10%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/14521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.84% <0.00%> (+2.10%)` | :arrow_up: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/14521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.56% <ø> (+8.67%)` | :arrow_up: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/14521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.56% <0.00%> (+6.83%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: