search

apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.47k stars 1.28k forks source link

Increase code coverage #5150

Open jackjlli opened 4 years ago

jackjlli commented 4 years ago

Currently the code coverage of pinot repo is just around 50% (Link). This issue tracks the status of increasing code coverage.

The following modules currently have less than 50% code coverage or don't have any test at all:

  1. pinot-clients/pinot-java-client (46.15%)
  2. pinot-common (47.96%)
  3. pinot-plugins (36.38%) No code coverage:
    • pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common
    • pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop
    • pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark
    • pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-stadardalone
    • pinot-plugins/pinot-file-system/pinot-gcs
    • pinot-plugins/pinot-file-system/pinot-hdfs

The rest of the modules shown below seems fine but we should still bring them to at least 75%. pinot-broker (76.6%) pinot-controller (63.29%) pinot-core (76.85%) pinot-minion (68.98%) pinot-server (67.05%) pinot-spi (68.84%)

visrahane commented 2 months ago

The code coverage link in the above comment is broken. Can someone please add the updated link with current code coverage? Is this the link? https://app.codecov.io/github/apache/pinot

jackjlli commented 2 months ago

Thanks @visrahane for the notice. The link is just updated.