apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.39k stars 1.26k forks source link

GuavaOnHeapBloomFilter can be constructed with _bloomFilter as null #5475

Open Sreemanth opened 4 years ago

Sreemanth commented 4 years ago

https://github.com/apache/incubator-pinot/blob/a314d42e8744549e5c182383445f11c60ac4ae4a/pinot-core/src/main/java/org/apache/pinot/core/bloom/GuavaOnHeapBloomFilter.java#L37

Because of default constructor _bloomFilter becomes null. add method of GuavaOnHeapBloomFilter will throw NullPointerException error.

kishoreg commented 4 years ago

@snleee is this valid?