search

apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.39k stars 1.26k forks source link

Minion will throw null point exception if protocol is null #7348

Open cxing opened 3 years ago

cxing commented 3 years ago

Need fix code: https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/SegmentFetcherFactory.java#L119

image

Jackie-Jiang commented 3 years ago

@cxing Thanks for reporting the issue. I believe this is caused by peer download where the download url is not set in the segment ZK metadata. Please verify if this is the case and we can make the fix properly

cxing commented 3 years ago

@cxing Thanks for reporting the issue. I believe this is caused by peer download where the download url is not set in the segment ZK metadata. Please verify if this is the case and we can make the fix properly

Hi @Jackie-Jiang Yes it's caused by the download url is not set in the segment ZK metadata, I think that can add null point check or it will throw null point exception