search

apache / pinot

Apache Pinot - A realtime distributed OLAP datastore
https://pinot.apache.org/
Apache License 2.0
5.27k stars 1.23k forks source link

Pinot minion doesn't have a healthcheck endpoint. #8515

Closed lfernandez93 closed 2 years ago

lfernandez93 commented 2 years ago

all the other pinot components offer a healtcheck endpoint but not the minion, even-though the helm chart references to it https://github.com/apache/pinot/blob/master/kubernetes/helm/pinot/templates/minion/statefulset.yml#L80 but it's disabled by default, it would be cool add a health check for this component as well so that we can have livenessProbes around it with kubernetes.

Jackie-Jiang commented 2 years ago

@lfernandez93 Good catch! Do you want to help contribute this? We can add a PinotMinionHealthCheck similar to PinotBrokerHealthCheck and add LifecycleServiceStatusCallback to the ServiceStatus

saurabhd336 commented 2 years ago

This has been enabled with https://github.com/apache/pinot/pull/8574 and https://github.com/apache/pinot/pull/8593