apache / plc4x

PLC4X The Industrial IoT adapter
https://plc4x.apache.org/
Apache License 2.0
1.23k stars 399 forks source link

Modbus TCP Timeout not working. NIFI Processor Task gets stuck #623

Closed ottlukas closed 1 week ago

ottlukas commented 1 year ago

When using V0.9.0 in PLC4x NIFI-Processor for Modbus TCP, the Processor Task gets stuck, if the network connection is broken. The default timeout and the request-timeout option do not seem to have any affect on this behaviour.

If the NIFI-Processor is started, when the network connection is already broken, a timeout error is thrown. If the connection breaks after a successful initial connection could be made, the running Task gets stuck on the next Modbus TCP Request and has to be forced to terminate.

Using V0.8.0 is working fine in the same scenario with same config in NIFI. In Production, V0.9.0 with Modbus TCP was not usable, since connections broke every day. We had to revert to V0.8.0. This was tested with the PLC4x Build from https://search.maven.org/search?q=plc4j-nifi-plc4x-nar and the official latest NIFI (V1.14.0) Docker and Windows Version 

Imported from Jira PLC4X-321. Original Jira may contain additional context. Reported by: zedman.

zhouzaihang commented 1 year ago

+1. plc4go has same bug.

zjee commented 1 year ago

same to me, Plc4xSourceProcessor 0.10.0 nifi-1.20.0

chrisdutz commented 3 weeks ago

A lot has changed, is this still an issue? I know much work has been put in some timeout handling in the last 2 years. If I don't hear otherwise, I will close this issue the next time I come across it.

chrisdutz commented 1 week ago

As this hasn not been re-reported and it's been open for a really long time, I assume that it has been resolved.